@marceloschmidt What happens when the result of search is based on usernames from messages (user autocomplete) and users are based on room's name (spotlight)?

This search will return names only when the data came from server.
Some results will have name (results from server) and others will not (results from client)

This will half work, and probably will cause confusion.

I think there are a few reasons why this PR should be approved. For starters, it's a setting that can be enabled/disabled. If disabled, there's no change on current functionality. Second, if someone searches by username, there's no impact, except that they will see some users' names; and if someone searches by name, they get the advantage of finding who they are looking for. The only names they won't see are the names belonging to users that have a message/subscription loaded... And I don't think that's a major drawback that justifies not approving this PR. If it can be improved later on, the better... but while it can't, I'd merge it.

Any chance this is going to get resolved? Real name search is unbelievable useful in corporate settings.

@marceloschmidt @rodrigok @engelgabriel I'd also like to ask if there is any chance that this feature gets merged soon. As mentioned in #4210 our users are strongly requesting a better LDAP integration. The current LDAP integration might cause that Rocket.Chat fails in enterprise environments as most enterprises have only cryptic user names and hence Rocket.Chat will be very hard to use :( Not sure how long I can keep our users waiting but I really want to avoid switching to another chat platform because I really do like Rocket.Chat.

@rodrigok @engelgabriel are you guys not going to merge this? if not, let's close it... are there change requests?

I think it should be merged 🤔

@marceloschmidt Can this PR be merged as soon as the merge conflicts has been solved? That would be awesome :)

@marceloschmidt this is great, Good job!! can't wait to use it.

@engelgabriel @rodrigok As the others already stated this is a sensible improvement. Rocket.Chat is currently under testing in my company and this is a feature many would like to see. So why is this issue ignored (for nearly 3 month)?

Please add this soon as this is a must have for us as we use 3 letters abbreviations for users which we have in full name from LDAP (in form of "XYZ | Real Name"} but users are not able to search by them.

@marceloschmidt @rodrigok is this worth solving the conflicts?

Due to our cryptic LDAP usernames and the recently improved search bar (which is great) in RC it's now almost impossible to start a new conversation with somebody you didn't chat yet if you don't ask him (e.g via phone) for his username :( So this makes things recently quite complicated. Hence I'd really appreciate this feature.

@engelgabriel I'd say it's well worth solving the merge conflicts, we too need this one. :)

@engelgabriel @rodrigok I don't think it's worth solving conflicts. We don't have a spotlight search anymore and the "add users to room" field already displays user names.

@subesokun @antgel how do you think this PR would benefit you? is there anything else we can do to improve your experience (assuming you have tested our latest version)?

@marceloschmidt my issue with the search has been solved via 4f54238 from @alexbrazier 👍